[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 24 08:18:25 PDT 2018


ioeric added inline comments.


================
Comment at: clangd/ClangdLSPServer.cpp:483
+  // Destroy ClangdServer to ensure all worker threads finish.
+  Server.reset();
 
----------------
This woudn't work if `run()` is called multiple times. Maybe create a `Server` in each `run()`? 


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52420





More information about the cfe-commits mailing list