[PATCH] D52402: [CMake][Fuchsia] Use internal_linkage rather than always_inline for libc++

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 23 01:04:50 PDT 2018


phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: EricWF.

This is a workaround for PR39053 which was uncovered by https://reviews.llvm.org/D50652 when
the default attribute has been changed from internal_linkage to
always_inline.


Repository:
  rC Clang

https://reviews.llvm.org/D52402

Files:
  clang/cmake/caches/Fuchsia-stage2.cmake


Index: clang/cmake/caches/Fuchsia-stage2.cmake
===================================================================
--- clang/cmake/caches/Fuchsia-stage2.cmake
+++ clang/cmake/caches/Fuchsia-stage2.cmake
@@ -109,6 +109,8 @@
     set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
     set(RUNTIMES_${target}-fuchsia_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
     set(RUNTIMES_${target}-fuchsia_LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY OFF CACHE BOOL "")
+    # TODO: this is a workaround for PR39053 which was uncovered by D50652.
+    set(RUNTIMES_${target}-fuchsia_LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT ON CACHE BOOL "")
   endforeach()
 
   set(LLVM_RUNTIME_SANITIZERS "Address" CACHE STRING "")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52402.166630.patch
Type: text/x-patch
Size: 733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180923/7432897d/attachment.bin>


More information about the cfe-commits mailing list