[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 22 16:05:46 PDT 2018


kristina marked 3 inline comments as done.
kristina added a comment.

Want to see what @rnk has to say about this before landing it since he wrote the original code and if my understanding of `common` vs `dso_local` is accurate or not since I don't have much experience with the Windows specific metadata, so I'll likely land it on Monday if he's happy with it. I kept `cfstring` as is, without the dot as per comment and now ELF and PE/COFF share the same paths sans the `DLLImport/DLLExport` part.


Repository:
  rC Clang

https://reviews.llvm.org/D52344





More information about the cfe-commits mailing list