[PATCH] D45179: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre-C++2a [[nodiscard]]

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D45179#1242896, @EricWF wrote:

> In https://reviews.llvm.org/D45179#1241721, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D45179#1225911, @EricWF wrote:
> >
> > > I don't think it ever landed. I'll try to get it in this week.
> >
> >
> > What does this need?
> >  Is there some changes missing still?
> >  Or this simply needs to be committed (and bots watched?)
>
>
> I think this was good to go. I was just waiting to give time for comments. Obviously I've waited long enough.


Ah, great.

> I'll work on this today.

If wanted, i can commandeer this back and land.


https://reviews.llvm.org/D45179