[PATCH] D52339: Support enums with a fixed underlying type in all language modes

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 21 11:24:16 PDT 2018


erik.pilkington added reviewers: jlebar, Anastasia.
erik.pilkington added subscribers: jlebar, Anastasia.
erik.pilkington added inline comments.


================
Comment at: clang/include/clang/Basic/Features.def:233
 EXTENSION(cxx_variadic_templates, LangOpts.CPlusPlus)
+EXTENSION(cxx_fixed_enum, true)
 // C++14 features supported by other languages as extensions.
----------------
aaron.ballman wrote:
> erik.pilkington wrote:
> > aaron.ballman wrote:
> > > Are we sure we want to make this decision for things like OpenCL, Cuda, etc?
> > I can't think of any reason why not, seems there are a handful of other EXTENSION(*, true) features. Do you have a preference?
> I think we should probably ask folks from the projects to see if they're okay with the extension or not, but I'd guess this won't be contentious.
Sure, @jlebar and @Anastasia: Any thoughts here?


Repository:
  rC Clang

https://reviews.llvm.org/D52339





More information about the cfe-commits mailing list