[PATCH] D52339: Support enums with a fixed underlying type in all language modes

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 21 10:44:13 PDT 2018


erik.pilkington added inline comments.


================
Comment at: clang/include/clang/Basic/Features.def:90
 FEATURE(objc_default_synthesize_properties, LangOpts.ObjC2)
-FEATURE(objc_fixed_enum, LangOpts.ObjC2)
+FEATURE(objc_fixed_enum, true)
 FEATURE(objc_instancetype, LangOpts.ObjC2)
----------------
erik.pilkington wrote:
> aaron.ballman wrote:
> > Is this really supported in ObjC1, or is there no longer a distinction to be made there?
> I suppose it's a first class feature in ObjC2, but an extension in ObjC1. On second thought I should probably not change this, because ObjC1 doesn't have this as a feature, although it does have it as an extension. 
On third thought, it looks like we never even try to compile with ObjC1 = 1 and ObjC2 = 0, so I guess this is fine as-is.


Repository:
  rC Clang

https://reviews.llvm.org/D52339





More information about the cfe-commits mailing list