[PATCH] D52339: Support enums with a fixed underlying type in all language modes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 21 07:58:14 PDT 2018


aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

I really like this idea in general, thank you for proposing this patch!



================
Comment at: clang/include/clang/Basic/Features.def:90
 FEATURE(objc_default_synthesize_properties, LangOpts.ObjC2)
-FEATURE(objc_fixed_enum, LangOpts.ObjC2)
+FEATURE(objc_fixed_enum, true)
 FEATURE(objc_instancetype, LangOpts.ObjC2)
----------------
Is this really supported in ObjC1, or is there no longer a distinction to be made there?


================
Comment at: clang/include/clang/Basic/Features.def:233
 EXTENSION(cxx_variadic_templates, LangOpts.CPlusPlus)
+EXTENSION(cxx_fixed_enum, true)
 // C++14 features supported by other languages as extensions.
----------------
Are we sure we want to make this decision for things like OpenCL, Cuda, etc?


Repository:
  rC Clang

https://reviews.llvm.org/D52339





More information about the cfe-commits mailing list