[PATCH] D52315: [clang-tidy] Fix for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 20 10:29:23 PDT 2018


lebedev.ri added a comment.

This looks questionable to me.
I don't disagree with the reasons stated about llvm types.
But is that *always* true?
I would personally be very surprized, and consider this a false-positive.

This should at least be optional.
Not sure about the default, but setting the `StrictMode` should certainly disable this relaxation.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52315





More information about the cfe-commits mailing list