[PATCH] D52308: [Sema][CodeCompletion] Fix return type of C++ destructors in code completion

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 20 08:59:22 PDT 2018


jkorous added a comment.

You might be right - I am assuming here that we want consistent behaviour between constructors and destructors.

IIUC ctors are currently skipped in code completions (in most cases) but they also don't have any type associated while result of their call definitely has some type.

Currently we are showing destructors in code completion in clangd (with detail "void") - that's actually how I noticed this.

I would assume that canonical type in function/method code completion is "it's type" not "type of result of it's call". WDYT?


Repository:
  rC Clang

https://reviews.llvm.org/D52308





More information about the cfe-commits mailing list