[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

Delesley Hutchins via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 19 12:21:32 PDT 2018


delesley accepted this revision.
delesley added a comment.
This revision is now accepted and ready to land.

This looks okay to me, but I have not tested it on a large code base to see if it breaks anything.



================
Comment at: lib/Sema/SemaDeclAttr.cpp:589
+            << AL << MD->getParent();
+    } else
+      S.Diag(AL.getLoc(), diag::warn_thread_attribute_not_on_non_static_member)
----------------
Curly braces around the else section.


Repository:
  rC Clang

https://reviews.llvm.org/D51901





More information about the cfe-commits mailing list