[PATCH] D52273: [clangd] Initial implementation of expected types

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/ExpectedTypes.h:119
+  explicit SType(SHA1Array Data);
+  SHA1Array Data;
+};
----------------
I assume this will be controversial. Happy to discuss/change.
We are currently building this representation based on USRs for types, the alternative is to store the USRs directly. Would be a bit more debuggable/explainable in case of failures, but also not particularly readable.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52273