[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 18 17:11:48 PDT 2018


aaronpuchert marked 2 inline comments as done.
aaronpuchert added a comment.

I think it should be possible to get rid of `self->` in the warning message if we want to, after all `this->` is omitted in C++ as well.



================
Comment at: test/SemaObjCXX/warn-thread-safety-analysis.mm:42
+  value_ -= 1;
+} // expected-warning{{mutex 'self->lock_' is still held at the end of function}}
+
----------------
@rjmccall Would you rather write `self->lock_` or `lock_` in the warning message?


Repository:
  rC Clang

https://reviews.llvm.org/D52200





More information about the cfe-commits mailing list