[PATCH] D52084: [clangd] Improve PostingList iterator string representation

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 18 10:08:47 PDT 2018


sammccall accepted this revision.
sammccall added a comment.

This change seems fine but...

This representation with the raw DocIDs and position dumped seems mostly useful for debugging buggy iterator implementations, but not really useful for understanding query structure and behavior.

I thought we might be replacing this soon. Of course there's no fundamental reason we can't keep both but I'm curious why this is an area of focus :-)


https://reviews.llvm.org/D52084





More information about the cfe-commits mailing list