[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/index/FileIndex.h:77
+  /// Update symbols from main file \p Path with symbols in \p TopLevelDecls.
+  void updateMain(PathRef Path, ASTContext &AST,
+                  std::shared_ptr<Preprocessor> PP,
----------------
sammccall wrote:
> sammccall wrote:
> > can't this just take PathRef + ParsedAST?
> > (same data, but clearer semantics)
> You're still taking the top-level decls, these can just come from the ParsedAST though?
Ah right. Sorry! Sent rL342473.


Repository:
  rL LLVM

https://reviews.llvm.org/D52222