[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ marked an inline comment as done.
NoQ added a comment.

> Should not it we have its own test in `expr-inspection.c`?

This isn't usually necessary when we're testing all code paths anyway, but i guess it's worth it to test our sanity-check warnings.



================
Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:65
 REGISTER_SET_WITH_PROGRAMSTATE(MarkedSymbols, SymbolRef)
+REGISTER_MAP_WITH_PROGRAMSTATE(DenotedSymbols, SymbolRef, const void *)
 
----------------
baloghadamsoftware wrote:
> Why const `void *`?
Whoops, i was incorrectly recalling that it doesn't work because the respective type trait structures aren't defined for non-void pointers, but that must have been some other data structure.


https://reviews.llvm.org/D52133