[PATCH] D51432: [AArch64] Unwinding support for return address signing

[Luke Cheeseman via Phabricator via cfe-commits]

LukeCheeseman added inline comments.


================
Comment at: src/Registers.hpp:1835
+  if (((regNum >= 0) && (regNum < 32)) || regNum == UNW_ARM64_RA_SIGN_STATE)
     return _registers.__x[regNum];
+
----------------
olista01 wrote:
> When regNum == UNW_ARM64_RA_SIGN_STATE, the index into __x is out of range. We'll need to add new storage to hold this value, I'd suggest replacing the current padding value in the GPRs struct, as that will avoid changing the layout expected by the context save/restore functions.
Good catch. Thanks, I didn't check the struct definition.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D51432