[PATCH] D45741: Python bindings: Fix handling of file bodies with multi-byte characters

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 16 12:12:35 PDT 2018


kristina added a comment.

Would you mind re-uploading these patches with full context (with `diff -U99999`). 3 lines of context around changes makes this very difficult to review. Also I would suggest testing for Python version and using appropriate semantics (using `encode` in case of Python3). Not entirely sure if the bindings are supposed to be compatible with Python3, but I don't see any harm. However explicit tests that avoid changing functionality of existing Python2.7 code would be better in my opinion.


Repository:
  rC Clang

https://reviews.llvm.org/D45741





More information about the cfe-commits mailing list