[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 15 03:49:18 PDT 2018


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

> save an iteration over the loop's basic blocks (which is what getLoopLatch does)

I'm not sure this is true. getLoopLatch() in LoopInfoImpl.h 
only traverses the children of the header in the inverse graph.
That should, I think, be similar to predecessors(Header) in case
of the IR CFG.

That being said, the patch makes sense to me and it is a simple,
straightforward improvement. I don't see any downsides and
it simplifies the code.

LGTM


Repository:
  rC Clang

https://reviews.llvm.org/D52118





More information about the cfe-commits mailing list