[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

[Matthew Voss via Phabricator via cfe-commits]

ormris added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3126
+  } else {
+    templateParameters = nullptr;//llvm::DINodeArray().get();
+  }
----------------
JDevlieghere wrote:
> What's the meaning of this comment? 
Hmm... That should be removed.


================
Comment at: lib/CodeGen/CGDebugInfo.h:654
+                           StringRef &LinkageName,
+                           llvm::MDTuple *&templateParameters,
+                           llvm::DIScope *&VDContext);
----------------
JDevlieghere wrote:
> s/templateParameters/TemplateParameters/ (same for the rest of this patch)
OK. Will fix.


Repository:
  rC Clang

https://reviews.llvm.org/D52058