[PATCH] D51333: Diagnose likely typos in include statements

Christy Lee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 13 12:33:56 PDT 2018


christylee added a comment.

@rsmith , thanks for the review, I fixed the variable capitalization.  If you could land it for me that'll be awesome!

In https://reviews.llvm.org/D51333#1233042, @sammccall wrote:

> One thing I'd like to do sometime is add code completion of filenames in #include directives.
>  This would mean listing the relevant directories from the include path. (VFS is slow for this today, but I have a patch out for it).
>
> Maybe it would make sense to do that here and use edit-distance to pick the suggestion, like typo correction elsewhere?
>  Could be a way to extend this patch's behavior in the future.


I also think it's a good idea.  I'm happy to take a crack at it!


https://reviews.llvm.org/D51333





More information about the cfe-commits mailing list