[libcxx] r342103 - Mark LWG#3102 as complete. No code changes, but I updated a test or two

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 12 19:23:52 PDT 2018


Author: marshall
Date: Wed Sep 12 19:23:52 2018
New Revision: 342103

URL: http://llvm.org/viewvc/llvm-project?rev=342103&view=rev
Log:
Mark LWG#3102 as complete. No code changes, but I updated a test or two

Modified:
    libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp
    libcxx/trunk/www/cxx2a_status.html

Modified: libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp?rev=342103&r1=342102&r2=342103&view=diff
==============================================================================
--- libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp (original)
+++ libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp Wed Sep 12 19:23:52 2018
@@ -32,8 +32,11 @@ constexpr bool testConstexprSpan(Span s)
     }
     else
     {
+    	typename Span::const_pointer last = &*(s.cbegin() + s.size() - 1);
         ret = ret &&  ( e !=  s.begin());
         ret = ret &&  (ce != s.cbegin());
+        ret = ret &&  (&*( e-1) == last);
+        ret = ret &&  (&*(ce-1) == last);
     }
 
     ret = ret &&  (( e -  s.begin()) == s.size());
@@ -55,8 +58,11 @@ void testRuntimeSpan(Span s)
     }
     else
     {
+    	typename Span::const_pointer last = &*(s.cbegin() + s.size() - 1);
         assert( e !=  s.begin());
         assert(ce != s.cbegin());
+        assert( &*( e-1) == last);
+        assert( &*(ce-1) == last);
     }
 
     assert(( e -  s.begin()) == s.size());

Modified: libcxx/trunk/www/cxx2a_status.html
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/cxx2a_status.html?rev=342103&r1=342102&r2=342103&view=diff
==============================================================================
--- libcxx/trunk/www/cxx2a_status.html (original)
+++ libcxx/trunk/www/cxx2a_status.html Wed Sep 12 19:23:52 2018
@@ -216,7 +216,7 @@
 	<tr><td><a href="https://wg21.link/LWG3083">3083</a></td><td>What should ios::iword(-1) do?</td><td>Rapperswil</td><td><i>Nothing to do</i></td></tr>
 	<tr><td><a href="https://wg21.link/LWG3094">3094</a></td><td>[time.duration.io]p4 makes surprising claims about encoding</td><td>Rapperswil</td><td></td></tr>
 	<tr><td><a href="https://wg21.link/LWG3100">3100</a></td><td>Unnecessary and confusing "empty span" wording</td><td>Rapperswil</td><td><i>Nothing to do</i></td></tr>
-	<tr><td><a href="https://wg21.link/LWG3102">3102</a></td><td>Clarify span iterator and const_iterator behavior</td><td>Rapperswil</td><td></td></tr>
+	<tr><td><a href="https://wg21.link/LWG3102">3102</a></td><td>Clarify span iterator and const_iterator behavior</td><td>Rapperswil</td><td>Complete</td></tr>
 	<tr><td><a href="https://wg21.link/LWG3104">3104</a></td><td>Fixing duration division</td><td>Rapperswil</td><td>Complete</td></tr>
 
 <!-- 	<tr><td></td><td></td><td></td><td></td></tr> -->




More information about the cfe-commits mailing list