[PATCH] D51090: [clangd] Add index benchmarks

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 11 08:30:47 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D51090#1230629, @sammccall wrote:

> In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote:
> >
> > > The only problem left is that I'm not sure how to run binary which is not under bin (`IndexBenchmark`) using llvm-lit.
> >
> >
> > But it's a //benchmark//.. What use could be from running it as part of the _tests_?
> >  For test-suite (lnt) integration, i'm not sure.
>
>
> Same as any other binary that isn't itself a test - make sure it works :-)
>  (Mostly just that it doesn't crash)


Then you don't actually care about the measurements, do you?
It would be a great idea to add `--benchmark_min_time=0.01` so it does not actually try to measure anything good.


https://reviews.llvm.org/D51090





More information about the cfe-commits mailing list