[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt:10
+  Dexp.cpp
+  )
+
----------------
Should we indent closing parens to the opening one or keep at the start of the line?
Let's pick one style and be consistent (the best option is being consistent with the rest of LLVM/clangd)


================
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:46
+
+template <class Function> void reportTime(StringRef Name, Function F) {
+  const auto TimerStart = std::chrono::high_resolution_clock::now();
----------------
NIT: Now that we ignore the return value, we could even remove templates:
```
void reportTime(StringRef Name, llvm::function_ref<void()> F);
```


https://reviews.llvm.org/D51628