[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 11 01:08:21 PDT 2018


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/index/Index.h:440
   /// return more than this, e.g. if it doesn't know which candidates are best.
-  size_t MaxCandidateCount = std::numeric_limits<size_t>::max();
+  uint32_t MaxCandidateCount = std::numeric_limits<uint32_t>::max();
   /// If set to true, only symbols for completion support will be considered.
----------------
ioeric wrote:
> Or use `unsigned`?
`unsigned` would have different size on different platforms, I'm not really sure we want that; could you elaborate on why you think that would be better?


https://reviews.llvm.org/D51860





More information about the cfe-commits mailing list