[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 18:48:05 PDT 2018


aaronpuchert added a comment.

The second warning message is a bit long, so if any of you have a better idea I'd welcome it.



================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3016-3017
+def warn_thread_attribute_not_on_capability_member : Warning<
+  "%0 attribute without capability arguments can only be applied in a class "
+  "annotated with 'capability' or 'scoped_lockable' attribute, but %1 isn't">,
+  InGroup<ThreadSafetyAttributes>, DefaultIgnore;
----------------
Alternative wording: "%0 attribute without capability arguments refers to 'this', but %1 isn't annotated with 'capability' or 'scoped_lockable' attribute".


Repository:
  rC Clang

https://reviews.llvm.org/D51901





More information about the cfe-commits mailing list