[PATCH] D51884: [clang-tidy] ExprMutationAnalyzer: construct from references. Fixes PR38888

Mon Sep 10 12:58:24 PDT 2018

lebedev.ri added a comment.

In https://reviews.llvm.org/D51884#1229460, @shuaiwang wrote:

> LGTM :)

Thank you for the review!

In https://reviews.llvm.org/D51884#1229463, @JonasToth wrote:

> I feel that the `findMutation...` functions that take raw pointers should get the assertions though, at least the ones in the public interface. Having them for the private ones won't hurt either.

I could do that.
But should that come with tests?
Or do we want to also take references there?

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51884