[PATCH] D51544: [OpenCL] Split opencl-c.h header

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 10:12:11 PDT 2018


Anastasia added a comment.

> With this setup, we can compile opencl-c-common.h, opencl-c-fp16.h and
>  opencl-c-fp64.h into PCHs with one set of extensions/OpenCL version,
>  and use them for any other set of extensions/OpenCL version. Clang
>  will detect this and throw out an error, which can be safely disabled
>  by -fno-validate-pch option.

However, keeping this as a permanent solution is unsafe. Because this way can result in unexpected errors to be silent out and allow erroneous configurations to be accepted successfully without any notification. So I am wondering if there is any plan to put a proper solution in place at some point?


Repository:
  rC Clang

https://reviews.llvm.org/D51544





More information about the cfe-commits mailing list