[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 06:54:31 PDT 2018


jkorous added a comment.

Sorry for the delay - I was busy with other things for past two weeks.



================
Comment at: Sema/SemaExpr.cpp:5338
             Context.DependentTy, VK_RValue, RParenLoc);
       } else {
 
----------------
JDevlieghere wrote:
> While you're at it you might as well remove the else branch here.
Sorry, I am not following. Do you mean just refactoring?

```
if a
  foo
else
  bar

```
->
```
if a
  foo

bar
```

Or do you really mean removing the else branch? I don't see how that would be NFC.


Repository:
  rC Clang

https://reviews.llvm.org/D51488





More information about the cfe-commits mailing list