[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

In https://reviews.llvm.org/D51038#1228618, @ilya-biryukov wrote:

> > Currently the problem is, there are again some tests out there that rely on
> >  CodeCompeleteOrdinaryName to be called even when getting overloads at an unknown
> >  parameter type
>
> CodeCompleteExpression works just fine there. Unknown parameter type should not block code completion.
>  The idea is that anywhere except the start of the argument expression, we need to call **only** signature help. At the start of the argument, we have to call both signature help and code completion.


Yeah you are right, I thought I could check whether I am inside a parameter or not by looking at qual type, which was apparently wrong :D

But, unfortunately, there were still tests failing which was caused by printing of completion strings for overloaded methods with optional parameters. It was trying to access Text field, which is not defined for Optional parameters.
Since it didn't print optional parameters in the original behavior I kept it that way. Can send it as a different patch if need be.


Repository:
  rC Clang

https://reviews.llvm.org/D51038