[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

[Don Hinton via Phabricator via cfe-commits]

hintonda added a comment.

Sorry for the late comment...

Are you amending an llvm commit or a clang commit?  The reason I ask is that if I amend an llvm commit, I have to update around 78 targets (llvm + clang + libcxx + libcxxabi + libunwind), but if I amend a clang commit, I only have to update 18 targets.

Since tools/clang/lib/Basic/SVNVersion.inc only includes revision number and repository for clang and llvm, the contents don't change on 'git commit --amend' of the clang repo.  Conversely, include/llvm/Support/VCSRevision.h includes the git hash, so it changes each time 'git commit --amend' is run on the llvm repo.

If the clang version is the one causing your problem, perhaps you could add a check to see if the file actually changed before overwriting it.  See llvm/include/llvm/Support/CMakeLists.txt for an example of how to do this, i.e., the "undef" case.


Repository:
  rC Clang

https://reviews.llvm.org/D47912