[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

[Takuto Ikuta via Phabricator via cfe-commits]

takuto.ikuta added a comment.

In https://reviews.llvm.org/D51340#1226989, @takuto.ikuta wrote:

> In https://reviews.llvm.org/D51340#1222013, @hans wrote:
>
> > Did both your builds use PCH? It'd be interesting to see the difference without PCH too; the effect should be even larger.
>
>
> Added stats of without PCH build.
>
> > The summary should probably reference https://bugs.llvm.org/show_bug.cgi?id=33628 and it needs to mention how it affects dllimport too.
>
> Added to description, thanks!
>
> > Okay, after reading through the patch, it seems we're still marking class members dllexport, and then you selectively remove the attribute later. That does feel a little bit backward... Does -fvisibility-inlines-hidden also have the static local problem, or how does that flag handle it?
>
> Ah, maybe I can get performance improvement just support fvisibility-inlines-hidden in clang-cl. Let me try.


I just support fvisibility-inlines-hidden in clang-cl and that looks to work intended.


https://reviews.llvm.org/D51340