[PATCH] D51752: NFC: move isRepeatedBytePattern from clang to Constant

[JF Bastien via Phabricator via cfe-commits]

jfb added a comment.

In https://reviews.llvm.org/D51752#1226465, @jfb wrote:

> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I'm not a good person to review clang changes.
> > - I assume the review lacks the changes on the llvm side?
> > - On the LLVM side this feels like something for `Analysis/ValueTracking.h` in fact I already see `Value *isBytewiseValue(Value *V);` there, maybe that is good enough for your purpose?
>
>
> Indeed, I just noticed the same. I'll try to figure out why it isn't firing where I want it to.


I think I'll just improve `isBytewiseValue` to do all the things `isRepeatedBytePattern` does. I'll update this patch to still delete `constantIsRepeatedBytePattern`, but use the new and improved `isBytewiseValue`.


Repository:
  rC Clang

https://reviews.llvm.org/D51752