[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

[Stephen Kelly via Phabricator via cfe-commits]

steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.

Brilliant, I've wanted to do this for years, and I still have many improvements to the LLVM/Clang cmake files on my todo list. Good to know others are similarly motivated.



================
Comment at: CMakeLists.txt:13
     message(STATUS "Found LLVM_CONFIG as ${LLVM_CONFIG}")
+    message(WARNING "Using llvm-config to detect the LLVM installation is \
+          deprecated.  The installed cmake files should be used \
----------------
message(DEPRECATION) is designed for deprecation messages. It announces itself as a "CMake Deprecation Warning at CMakeLists.txt:6 (message):".

The user can silence the warning with `-Wno-deprecated` or make it an error with `Wdeprecated` since old versions of CMake: https://cmake.org/pipermail/cmake-developers/2013-July/019634.html


Repository:
  rC Clang

https://reviews.llvm.org/D51714