[PATCH] D51388: [analyzer] NFC: Legalize state manager factory injection.

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 5 11:22:20 PDT 2018


george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h:33
   /// introduce a type named \c NameTy.
-  /// The macro should not be used inside namespaces, or for traits that must
-  /// be accessible from more than one translation unit.
+  /// The macro should not be used inside namespaces.
   #define REGISTER_TRAIT_WITH_PROGRAMSTATE(Name, Type) \
----------------
What happened to the comment about multiple TUs?
One still has to be very careful here, right?


Repository:
  rC Clang

https://reviews.llvm.org/D51388





More information about the cfe-commits mailing list