[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

[Whisperity via Phabricator via cfe-commits]

whisperity added a comment.

Whew, this is a big one. Generally looks good, although I would separate implementation detail functions a bit better, with perhaps more comments to move them apart a bit, it is really harsh to scroll through.

Could you please re-run the findings on the projects? There has been a lot of improvements to the checker.
I think we should review it as it is now, and do further enhancements later on, in subsequent patches, where the enhancement implementations themselves are revealed better in the diff.


https://reviews.llvm.org/D45050