[PATCH] D51528: [NFC] Cleanup Dex

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 01:15:46 PDT 2018


kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous.

- Use consistent assertion messages in iterators implementations
- Silence a bunch of clang-tidy warnings: use `emplace_back` instead of `push_back` where possible, make sure arguments have the same name in header and implementation file, use for loop over ranges where possible


https://reviews.llvm.org/D51528

Files:
  clang-tools-extra/clangd/index/dex/DexIndex.cpp
  clang-tools-extra/clangd/index/dex/DexIndex.h
  clang-tools-extra/clangd/index/dex/Iterator.cpp
  clang-tools-extra/clangd/index/dex/Trigram.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51528.163473.patch
Type: text/x-patch
Size: 9222 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180831/20a70362/attachment.bin>


More information about the cfe-commits mailing list