[PATCH] D51527: [NFC] Use LLVM naming conventions within FileDistance

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 00:54:15 PDT 2018


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/FileDistance.cpp:56
 
-constexpr const unsigned FileDistance::kUnreachable;
-
----------------
I think this is required - are you sure it's never ODR-used?
(Even if not, it's public, so it's not really possible to guarantee that)


https://reviews.llvm.org/D51527





More information about the cfe-commits mailing list