[PATCH] D51292: [docs] Update clang-rename documentation

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 07:08:43 PDT 2018


ilya-biryukov added a comment.

Leaving some comments, but also suggest getting the final LGTM from the owner of the doc (@ioeric?)



================
Comment at: clang-tools-extra/docs/clang-rename.rst:141
+:program:`clangd <https://clang.llvm.org/extra/clangd.html>`_ uses
+:program:`clang-rename` infrastructure to handle renaming requests. Currently,
+it only supports renaming symbol within a single file, but in the future it will
----------------
`handle renaming requests` seems to assume some familiarity with LSP. Maybe rephrase?


================
Comment at: clang-tools-extra/docs/clang-rename.rst:170
 `clang-rename/tool/clang-rename.el
-<http://reviews.llvm.org/diffusion/L/browse/clang-tools-extra/trunk/clang-rename/tool/clang-rename.el>`_.
+<https://reviews.llvm.org/diffusion/L/browse/cfe/trunk/tools/clang-rename/clang-rename.py>`_.
 
----------------
Accidentally linked to clang-rename.py instead clang-rename.el?


https://reviews.llvm.org/D51292





More information about the cfe-commits mailing list