[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

Is this a feature requested by users?

I can understand that this may be useful to pinpoint some conversions which are potentially harmful to performance. However such conversions can often be eliminated by optimization, which makes this warning less useful.

On the other hand, too many warnings is a nuance to users, therefore I am wondering whether this warning should be off by default.

Do you have any chance to have any feedback from users about how useful or intrusive this warning is.


https://reviews.llvm.org/D51411