[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 14:03:19 PDT 2018


mstorsjo created this revision.
mstorsjo added reviewers: rnk, pcc.

Since MinGW supports automatically importing external variables from DLLs even without the DLLImport attribute, we shouldn't mark them as DSO local unless we actually know them to be local for sure.

Keep marking thread local variables as DSO local.


Repository:
  rC Clang

https://reviews.llvm.org/D51382

Files:
  lib/CodeGen/CodeGenModule.cpp
  test/CodeGen/dllimport.c
  test/CodeGen/dso-local-executable.c
  test/CodeGenCXX/dllexport.cpp
  test/CodeGenCXX/dllimport-members.cpp
  test/CodeGenCXX/dllimport.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51382.162953.patch
Type: text/x-patch
Size: 5670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180828/c978404d/attachment.bin>


More information about the cfe-commits mailing list