[PATCH] D51321: [Tooling] Improve handling of CL-style options

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 27 14:16:40 PDT 2018


rnk added inline comments.


================
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:182-184
+      if (Arg->getOption().matches(driver::options::OPT_driver_mode)) {
+        // Process --driver-mode.
+        IsCLMode = std::strcmp(Arg->getValue(), "cl") == 0;
----------------
I think you need to do this up front, otherwise you'll parse some args in non-cl mode and some in cl mode.


Repository:
  rC Clang

https://reviews.llvm.org/D51321





More information about the cfe-commits mailing list