[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

Hugo Gonzalez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 24 08:42:31 PDT 2018


hugoeg added inline comments.


================
Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:37-38
+  // Those are handled on the ancestor call.
+  const auto CallToEither = callExpr(
+      callee(functionDecl(hasAnyName("::absl::StrCat", "::absl::StrAppend"))));
+  Finder->addMatcher(
----------------
aaron.ballman wrote:
> Can this be replaced by `anyOf(CallToStrcat, CallToStrappend)`?
I just tried it, it doesn't work, so we should probably keep it as is. 


https://reviews.llvm.org/D51132





More information about the cfe-commits mailing list