[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Andi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 24 08:34:12 PDT 2018


Abpostelnicu updated this revision to Diff 162387.

https://reviews.llvm.org/D49851

Files:
  clang-tidy/tool/run-clang-tidy.py


Index: clang-tidy/tool/run-clang-tidy.py
===================================================================
--- clang-tidy/tool/run-clang-tidy.py
+++ clang-tidy/tool/run-clang-tidy.py
@@ -166,10 +166,18 @@
     output, err = proc.communicate()
     if proc.returncode != 0:
       failed_files.append(name)
+
+    if is_py2:
+      output_string = output
+      err_string = err
+    else:
+      output_string = str(output, 'utf-8')
+      err_string = str(err, 'utf-8')
+
     with lock:
-      sys.stdout.write(' '.join(invocation) + '\n' + output + '\n')
-      if err > 0:
-        sys.stderr.write(err + '\n')
+      sys.stdout.write(' '.join(invocation) + '\n' + output_string + '\n')
+      if err:
+        sys.stderr.write(err_string + '\n')
     queue.task_done()
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49851.162387.patch
Type: text/x-patch
Size: 780 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180824/d8fcd5c3/attachment.bin>


More information about the cfe-commits mailing list