[PATCH] D51200: Introduce per-callsite inline intrinsics

Jakub Kuderski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 23 17:34:50 PDT 2018


kuhar added a comment.

Disclaimer: I'm a Clang newbie and I'm not sure if that's a good way to implement these intrinsics. I'm not sure about the following things:

- The new enum CallInlineKind may not be in the right place
- Not sure if adding the extra parameter to EmitSomething methods is the cleanest thing possible -- some functions have it now, some don't, and it makes argument lists longer
- Not sure if just adding an extra attribute at each callsite is enough -- I'm not sure what is supposed to happen when there are conflicting inline attributes at call sites and function declarations (e.g. `__builtin_always_inline` and `__attribute__ ((always_inline))`)
- I don't know how to handle constexpr functions
- I don't know how to implement it for constructor calls

I would really appreciate any tips here :).


Repository:
  rC Clang

https://reviews.llvm.org/D51200





More information about the cfe-commits mailing list