[PATCH] D50898: [clangd] Suggest code-completions for overriding base class virtual methods.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet updated this revision to Diff 162157.
kadircet added a comment.

- Resolve discussions.
- Move override generation logic from render to item generation so that internal clients can use it as well, also use a boolean for checking override status of a bundle to be more efficient.
- Change unittests accordingly, get rid of unused IsOverride field.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50898

Files:
  clangd/CodeComplete.cpp
  unittests/clangd/CodeCompleteTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50898.162157.patch
Type: text/x-patch
Size: 9106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180823/829d2cd8/attachment.bin>