[PATCH] D51154: [clangd] Log memory usage of DexIndex and MemIndex

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 23 04:55:53 PDT 2018


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:180
+  Bytes += SymbolQuality.size() * sizeof(std::pair<const Symbol *, float>);
+  Bytes += InvertedIndex.size() * sizeof(Token);
+  {
----------------
sammccall wrote:
> I think you're not counting the size of the actual symbols.
> This is difficult to do precisely, but avoiding it seems misleading (we have "shared ownership" but it's basically exclusive). What's the plan here?
As discussed offline: I should put a FIXME and leave it for later.


https://reviews.llvm.org/D51154





More information about the cfe-commits mailing list