[PATCH] D50738: Remove vestiges of configure buildsystem

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 23 04:51:19 PDT 2018


svenvh added inline comments.


================
Comment at: CMakeLists.txt:288
 
-if( CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR AND NOT MSVC_IDE )
-  message(FATAL_ERROR "In-source builds are not allowed. CMake would overwrite "
-"the makefiles distributed with LLVM. Please create a directory and run cmake "
+if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
+  message(FATAL_ERROR "In-source builds are not allowed. "
----------------
The `NOT MSVC_IDE` condition is still present in llvm's `CMakeLists.txt`, at least in r340526 (line 230), so not sure if we should remove it here?


Repository:
  rC Clang

https://reviews.llvm.org/D50738





More information about the cfe-commits mailing list