[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 22 02:28:25 PDT 2018


ilya-biryukov added a comment.

WRT to the configuration argument, using stack size suggested by @arphaman seems like a better option. So let's not add any extra options to clangd.



================
Comment at: clangd/Threading.cpp:76
+
+  if (::pthread_attr_setstacksize(&Attr, 8 * 1024 * 1024) != 0)
+    return;
----------------
arphaman wrote:
> please use clang::DesiredStackSize instead.
Oh, cool! TIL we have this. Thanks for mentioning it.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50993





More information about the cfe-commits mailing list