[PATCH] D51077: [clangd] send diagnostic categories only when 'categorySupport' capability was given by the client

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 17:38:14 PDT 2018


arphaman created this revision.
arphaman added a reviewer: ilya-biryukov.
Herald added subscribers: kadircet, dexonsmith, jkorous, MaskRay, ioeric.

After https://reviews.llvm.org/D50571 Clangd started sending categories with each diagnostic, but that broke the eglot client. This patch puts the categories behind a capability to fix that breakage.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51077

Files:
  clangd/ClangdLSPServer.cpp
  clangd/Diagnostics.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  test/clangd/compile-commands-path-in-initialize.test
  test/clangd/compile-commands-path.test
  test/clangd/diagnostic-category.test
  test/clangd/diagnostics.test
  test/clangd/did-change-configuration-params.test
  test/clangd/execute-command.test
  test/clangd/extra-flags.test
  test/clangd/fixits-embed-in-diagnostic.test
  test/clangd/fixits.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51077.161860.patch
Type: text/x-patch
Size: 10018 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180822/9a4b9b17/attachment-0001.bin>


More information about the cfe-commits mailing list