[PATCH] D51068: [Android] Default to -fno-math-errno

Stephen Hines via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 17:28:18 PDT 2018


srhines accepted this revision.
srhines added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Driver/ToolChains/Linux.cpp:913
+    return false;
+  return Generic_ELF::IsMathErrnoDefault();
+}
----------------
pirama wrote:
> I tried to be defensive here in case the default changes in the future.  I can simplify to just return true here if that'd be simpler.
I agree with this, since this matches the present behavior.


Repository:
  rC Clang

https://reviews.llvm.org/D51068





More information about the cfe-commits mailing list